[lldb/SwiftUserExpression] Simplify ScanContext logic #1180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedantk
commented
May 5, 2020
vedantk
commented
- Remove redundant null checks
- Add missing logging information
- Avoid re-computing the type of self and its type flags
|
@swift-ci test |
Allow Language() to be called from const methods within UserExpression. (cherry picked from commit 9e35498)
- Remove redundant null checks - Add missing logging information - Avoid re-computing the type of self and its type flags
|
@swift-ci test |
| if (sym_ctx.comp_unit && (expr.Language() == lldb::eLanguageTypeUnknown || | ||
| expr.Language() == lldb::eLanguageTypeSwift)) { | ||
| if (sym_ctx.comp_unit->GetLanguage() == lldb::eLanguageTypeSwift || | ||
| sym_ctx.comp_unit->GetLanguage() == lldb::eLanguageTypePLI) |
There was a problem hiding this comment.
We should really remove the PL1 line. This dates back to a brief period in 2013 before DW_LANG_Swift was defined and before DW_LANG_APPLE_Swift could be defined due to upstream LLVM contstraints.
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.