Skip to content

[AArch64] Don't promote constants with float ConstantExpr. #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fhahn
Copy link

@fhahn fhahn commented May 14, 2020

Currently the AsmPrinter cannot emit some floating point constant
expressions in global initializers. Avoid generating them.

Reviewers: dmgreen, t.p.northover, arsenm, efriedma, Gerolf

Reviewed By: efriedma

Differential Revision: https://reviews.llvm.org/D79865

@fhahn
Copy link
Author

fhahn commented May 15, 2020

@swift-ci please test

Currently the AsmPrinter cannot emit some floating point constant
expressions in global initializers. Avoid generating them.

Reviewers: dmgreen, t.p.northover, arsenm, efriedma, Gerolf

Reviewed By: efriedma

Differential Revision: https://reviews.llvm.org/D79865
@fhahn fhahn force-pushed the aarch64promoteconst-fix branch from 31cd55d to f1a0e2e Compare May 15, 2020 10:38
@fhahn
Copy link
Author

fhahn commented May 15, 2020

@swift-ci please test

1 similar comment
@fhahn
Copy link
Author

fhahn commented May 15, 2020

@swift-ci please test

@fhahn fhahn merged commit c106214 into swiftlang:apple/stable/20200108 May 15, 2020
@fhahn fhahn deleted the aarch64promoteconst-fix branch May 15, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant