Vanishing threads #1254
Merged
Vanishing threads #1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undefined reference to pthread_create I skipped the test till I can figure out why this didn't build.
200 microseconds is not enough time for any expression to execute reliably. On linux, calling pthread_exit can result in call to dlopen, which cannot complete in that time, particularly when running under a debugger. On linux, this test failed all the time, on macos, about two thirds of runs were failing. This patch increases the timeout to 100ms, which is enough to get it passing reliably on linux, though I wouldn't be surprised if an even bigger timeout would be needed for remote test runs.
covered switch warning.
|
This touches only lldb, which is not tested by PRs. I'm merging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the case where the thread we are running an expression on exits while running the expression.