-
Notifications
You must be signed in to change notification settings - Fork 344
[lldb/formatter] Add Swift.UnsafeBufferPointer data formatter #1276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci test |
lldb/test/API/functionalities/data-formatter/swift-unsafe/main.swift
Outdated
Show resolved
Hide resolved
lldb/test/API/functionalities/data-formatter/swift-unsafe/main.swift
Outdated
Show resolved
Hide resolved
lldb/test/API/functionalities/data-formatter/swift-unsafe/main.swift
Outdated
Show resolved
Hide resolved
lldb/test/API/functionalities/data-formatter/swift-unsafe/TestSwiftUnsafeTypeFormatters.py
Outdated
Show resolved
Hide resolved
lldb/test/API/functionalities/data-formatter/swift-unsafe/TestSwiftUnsafeTypeFormatters.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this. While I think the logic is mostly correct, this opens the opportunity to do some things better. I outlined some of my concerns inline.
lldb/test/API/functionalities/data-formatter/swift-unsafe/TestSwiftUnsafeTypeFormatters.py
Outdated
Show resolved
Hide resolved
lldb/test/API/functionalities/data-formatter/swift-unsafe/TestSwiftUnsafeTypeFormatters.py
Outdated
Show resolved
Hide resolved
lldb/test/API/functionalities/data-formatter/swift-unsafe/main.swift
Outdated
Show resolved
Hide resolved
lldb/test/API/functionalities/data-formatter/swift-unsafe/TestSwiftUnsafeTypeFormatters.py
Outdated
Show resolved
Hide resolved
26566a6
to
ef18610
Compare
I updated the patch to address @dcci and @fredriss comments:
|
4653409
to
ad27f43
Compare
@swift-ci test |
ad27f43
to
0192b51
Compare
@swift-ci test |
lldb/test/API/functionalities/data-formatter/swift-unsafe/TestSwiftUnsafeTypeFormatters.py
Outdated
Show resolved
Hide resolved
lldb/test/API/functionalities/data-formatter/swift-unsafe/main.swift
Outdated
Show resolved
Hide resolved
0192b51
to
83961c0
Compare
@swift-ci test |
Added more tests (value associated enums, generic class, existential type (archetypes) ...) |
The macOS failure happened on a Swift test. Given that I only touched to LLDB, I assume this is a flaky test. |
@swift-ci test macOS Platform |
swiftlang/swift#32152 Should fix the test failure. Let's try re-running the macOS CI again! |
@swift-ci test macOS Platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After you address this last round of comments, this LGTM
This patch adds support for Swift's UnsafeBufferPointer and UnsafeMutableBufferPointer data formatting. It introduces a summary provider and a synthetic frontend creator for these types. Signed-off-by: Med Ismail Bennani <[email protected]>
83961c0
to
df9551d
Compare
@swift-ci test |
@swift-ci test macOS Platform |
This patch adds support for Swift's UnsafeBufferPointer and
UnsafeMutableBufferPointer data formatting.
It introduces a summary provider and a synthetic frontend creator for
these types.
Signed-off-by: Med Ismail Bennani [email protected]