[lldb] Fix that SIGWINCH crashes IOHandlerEditline when we are not us… #1411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the editline backend Summary: TerminalSizeChanged is called from our SIGWINCH signal handler but the IOHandlerEditline currently doesn't check if we are actually using the real editline backend. If we're not using the real editline backend, `m_editline_up` won't be set and `IOHandlerEditline::TerminalSizeChanged` will access the empty unique_ptr. In a real use case we don't use the editline backend when we for example read input from a file. We also create some temporary IOHandlerEditline's during LLDB startup it seems that are also treated as non-interactive (apparently to read startup commands). This patch just adds a nullptr check for`m_editline_up` as we do in the rest of IOHandlerEditline. Fixes rdar://problem/63921950 Reviewers: labath, friss Reviewed By: friss Subscribers: abidh, JDevlieghere Differential Revision: https://reviews.llvm.org/D81729 (cherry picked from commit be18df3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing the editline backend
Summary:
TerminalSizeChanged is called from our SIGWINCH signal handler but the
IOHandlerEditline currently doesn't check if we are actually using the real
editline backend. If we're not using the real editline backend,
m_editline_upwon't be set and
IOHandlerEditline::TerminalSizeChangedwill accessthe empty unique_ptr. In a real use case we don't use the editline backend
when we for example read input from a file. We also create some temporary
IOHandlerEditline's during LLDB startup it seems that are also treated
as non-interactive (apparently to read startup commands).
This patch just adds a nullptr check for
m_editline_upas we do in the rest ofIOHandlerEditline.
Fixes rdar://problem/63921950
Reviewers: labath, friss
Reviewed By: friss
Subscribers: abidh, JDevlieghere
Differential Revision: https://reviews.llvm.org/D81729
(cherry picked from commit be18df3)