Fix Pavel's patch for ValueObjectVariables with complex DWARF express… #1437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions to work with Swift's complex Synthetic variable structures. Pavel's patch is appropriate for children of ValueObjectVariables but not for synthetic children. This patch ensures that we only do the computation where appropriate. The patch is being discussed w.r.t. the llvm.org sources as: https://reviews.llvm.org/D83450 This change is to get it onto the 5.3 branch w/o having to wait for the resolution of that discussion. <rdar://problem/64209516>
|
@swift-ci please test |
patch for the swift-5.3 branch.
|
This built/tested fine previously except for an unrelated test that had been introduced by mistake by the previous version of the PR. I'm going to merge this without retesting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ions
to work with Swift's complex Synthetic variable structures.
Pavel's patch is appropriate for children of ValueObjectVariables but
not for synthetic children. This patch ensures that we only do the
computation where appropriate.
The patch is being discussed w.r.t. the llvm.org sources as:
https://reviews.llvm.org/D83450
This change is to get it onto the 5.3 branch w/o having to wait for
the resolution of that discussion.
rdar://problem/64209516