Target: correct binding variable type (NFC) #1446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The returned type for `GetScratchSwiftASTContext` is `llvm::Optional<SwiftASTContextReader>` which cannot be unwrapped. Use `auto` and a reference binding rather than the copy-constructor and unbound type. This repairs the build with MSVC.
|
@swift-ci please test |
|
CC: @nate-chandler |
|
The auto-merge from swift/release/5.3 to swift/master must have caused this breakage, since 5.3 doesn't have the change to make |
|
@vedantk no worries - the lldb branching is pretty complicated. |
|
@swift-ci please test |
This was referenced Jul 14, 2020
|
This also broke building with top-of-tree clang. Thanks for fixing this @compnerd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The returned type for
GetScratchSwiftASTContextisllvm::Optional<SwiftASTContextReader>which cannot be unwrapped. Useautoand a reference binding rather than the copy-constructor andunbound type. This repairs the build with MSVC.