Skip to content

Rename SerializedModuleLoader to match Swift compiler's new API. #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2020
Merged

Rename SerializedModuleLoader to match Swift compiler's new API. #1465

merged 1 commit into from
Jul 22, 2020

Conversation

artemcm
Copy link

@artemcm artemcm commented Jul 15, 2020

swiftlang/swift#32903 makes some changes to the module loader structure, including a renaming of SerializedModuleLoader to ImplicitSerializedModuleLoader. This PR is a required companion to that change.

@artemcm artemcm mentioned this pull request Jul 15, 2020
Merged
@artemcm
Copy link
Author

artemcm commented Jul 15, 2020

Please test with following PR:
swiftlang/swift#32903

@swift-ci Please test

@artemcm artemcm requested a review from nkcsgexi July 15, 2020 21:17
nkcsgexi
nkcsgexi approved these changes Jul 15, 2020
View reviewed changes
Copy link

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a really safe change.

@artemcm
Copy link
Author

artemcm commented Jul 16, 2020

Please test with following PR:
swiftlang/swift#32903

@swift-ci Please test

3 similar comments
@artemcm
Copy link
Author

artemcm commented Jul 17, 2020

Please test with following PR:
swiftlang/swift#32903

@swift-ci Please test

@artemcm
Copy link
Author

artemcm commented Jul 17, 2020

Please test with following PR:
swiftlang/swift#32903

@swift-ci Please test

@artemcm
Copy link
Author

artemcm commented Jul 17, 2020

Please test with following PR:
swiftlang/swift#32903

@swift-ci Please test

@artemcm
Copy link
Author

artemcm commented Jul 20, 2020

Please test with following PR:
swiftlang/swift#32903

@swift-ci Please test

@hamishknight
Copy link

Note you'll also need to cherry-pick this change to swift/master-next and swift/master-rebranch, as we don't have automergers for them.

@artemcm
Copy link
Author

artemcm commented Jul 21, 2020

Please test with following PR:
swiftlang/swift#32903

@swift-ci Please test

1 similar comment
@artemcm
Copy link
Author

artemcm commented Jul 21, 2020

Please test with following PR:
swiftlang/swift#32903

@swift-ci Please test

@artemcm artemcm merged commit dbf7d18 into swiftlang:swift/master Jul 22, 2020
@hamishknight
Copy link

Please don't forget to cherry-pick to swift/master-next and swift/master-rebranch, as those branches will be unable to build LLDB when the Swift automergers pick up the Swift half of this change.

This was referenced Jul 22, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artemcm @hamishknight @nkcsgexi