Skip to content

[lldb] Fix compile error due implicit StringRef -> std::string conversion #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2020
Merged

[lldb] Fix compile error due implicit StringRef -> std::string conversion #1510

merged 1 commit into from
Jul 20, 2020

Conversation

Teemperor
Copy link

This was failing with:

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1276:24: error: no viable overloaded '='
  module->APINotesFile = apinotes;
  ~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~
include/c++/v1/string:877:19: note: candidate function not viable: no known conversion from 'llvm::StringRef' to 'const std::__1::basic_string<char>' for 1st argument
    basic_string& operator=(const basic_string& __str);
                  ^

@Teemperor
[lldb] Fix compile error due implicit StringRef -> std::string conver…
5206ce5 
…sion

This was failing with:
```
lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:1276:24: error: no viable overloaded '='
  module->APINotesFile = apinotes;
  ~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~
include/c++/v1/string:877:19: note: candidate function not viable: no known conversion from 'llvm::StringRef' to 'const std::__1::basic_string<char>' for 1st argument
    basic_string& operator=(const basic_string& __str);
                  ^
```
@Teemperor Teemperor requested a review from JDevlieghere July 20, 2020 15:36
@fredriss fredriss merged commit 500b8af into swiftlang:apple/stable/20200714 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JDevlieghere JDevlieghere Awaiting requested review from JDevlieghere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Teemperor @fredriss