SwiftASTContext: allow deserializing @_implementationOnly dependencies to avoid crashing #1625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to avoid crashing rdar://65570721
|
@swift-ci please test |
|
@adrian-prantl can you think of any way to test this in LLDB? |
|
@swift-ci please test |
|
@fredriss It seems we do have an existing test covering this case: |
nkcsgexi
force-pushed
the
65570721-swift-master
branch
from
492d32a to
ee8bae4
Compare
|
@swift-ci please test |
nkcsgexi
force-pushed
the
65570721-swift-master
branch
from
ee8bae4 to
d0d71b5
Compare
|
@swift-ci please test |
nkcsgexi
force-pushed
the
65570721-swift-master
branch
from
d0d71b5 to
f7d1faf
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test |
nkcsgexi
force-pushed
the
65570721-swift-master
branch
from
f7d1faf to
a957e0e
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test |
nkcsgexi
force-pushed
the
65570721-swift-master
branch
from
a957e0e to
818ebca
Compare
|
@swift-ci please test |
adrian-prantl
approved these changes
Aug 11, 2020
|
@nkcsgexi please also create pull requests against master-rebranch and master-next. We don't have automergers in that direction. |
|
@adrian-prantl yeah. I'll merge to these branches using #1627 and #1626 |
|
@nkcsgexi Awesome. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://65570721