Target: explicitly convert StringRef to std::string
#1677
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has changed in upstream LLVM and `StringRef` is no longer implicitly convertible to `std::string`. Adjust the invocation to allow the rebranched lldb to build.
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
LGTM — don't forget to cherry-pick to master-next! |
compnerd
force-pushed
the
explicit-conversion
branch
2 times, most recently
from
6ddd0ee to
54722a7
Compare
|
Ugh, pushed to the wrong branch. Thanks for the reminder though @adrian-prantl! |
|
@compnerd done! |
|
Excellent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has changed in upstream LLVM and
StringRefis no longerimplicitly convertible to
std::string. Adjust the invocation to allowthe rebranched lldb to build.