[lldb/interpreter] Add Swift REPL init file support #1717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test linux platform |
medismailben
force-pushed
the
swift/master-rebranch
branch
from
510a0d2 to
6e9b74b
Compare
|
@swift-ci test |
|
@swift-ci please test linux |
JDevlieghere
previously requested changes
Sep 1, 2020
medismailben
force-pushed
the
swift/master-rebranch
branch
3 times, most recently
from
cc8b780 to
19953a1
Compare
|
I'll move this to llvm.org, and cherrypick it afterwards. |
Provider a wrapper around llvm::sys::path::home_directory in the FileSystem class. This will make it possible for the reproducers to intercept the call in a central place.
medismailben
force-pushed
the
swift/master-rebranch
branch
from
19953a1 to
3cec419
Compare
medismailben
changed the base branch from
swift/master-rebranch
to
swift/master
This patch changes the command interpreter sourcing logic for the REPL
init file. Instead of looking for a arbitrary file name, it standardizes
the REPL init file name to match to following scheme:
`.lldbinit-<language>-repl`
This will make the naming more homogenous and the sourcing logic future-proof.
rdar://65836048
Differential Revision: https://reviews.llvm.org/D86987
Signed-off-by: Med Ismail Bennani <[email protected]>
Previously, before loading the REPL language-specific init file, lldb checked the selected target language in which case it returned an unknown language type with the REPL target. Instead, the patch calls `Language::GetLanguagesSupportingREPLs` and look for the first element of that set. In case lldb was not configured with a REPL language, then, it will just stop sourcing the REPL init file and fallback to the original logic (continuing with the default init file). rdar://65836048 Differential Revision: https://reviews.llvm.org/D87076 Signed-off-by: Med Ismail Bennani <[email protected]>
This test adds `breakpoint set` commands with different source locations to a temporary `.lldbinit-swift-repl` and `.lldbinit` and after launching lldb, it checks that the breakpoint set in the debugger matches the source location from the SwiftREPL initfile. rdar://65836048 Signed-off-by: Med Ismail Bennani <[email protected]>
medismailben
force-pushed
the
swift/master-rebranch
branch
from
3cec419 to
c1bba7c
Compare
medismailben
dismissed
JDevlieghere’s stale review
52d43e1 handles the change on llvm.org
|
@swift-ci test |
|
Did you also cherry-pick the llvm.org patches to the Bastille branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users complained that when using the Swift REPL (LLDB launched with
--reploption), it would try to read their home init file, which can causeunintended behaviour.
To solve this issue, this patch introduces a new, more specific, Swift
REPL init file, conveniently named
.lldbinit-swift-repl. If the usercreates this file in his home directory, and launches LLDB in REPL mode,
it will override the default init file.
This behaviour only applies when REPL mode is enabled.
rdar://65836048
Signed-off-by: Med Ismail Bennani [email protected]