[lldb/formatter] Format single valued OptionSets w/o brackets #1728
Conversation
|
Nice! |
|
My understanding is that swiftlang/swift#33731 is imminent, so we might want to hold off on actually merging this until the rebranch is complete. (Fingers crossed that it will actually happen soon). |
It's a good practice to add the bug tracking number in your commit/PR so people can get more context/history of what you're working on 🙂 |
|
@medismailben thanks, done. |
Even better: Since your change doesn't need anything in master-rebranch, you can just do it in swift/master and swift/master-next — and it will be picked up by the rebranch automatically. |
kastiglione
changed the base branch from
swift/master-rebranch
to
apple/master
|
I've retargeted this PR to swift/master. |
| @@ -167,6 +167,12 @@ bool lldb_private::formatters::swift::SwiftOptionSetSummaryProvider:: | |||
|
|
|||
| for (auto val_name : *m_cases) { | |||
| llvm::APInt case_value = val_name.first; | |||
| // Print single valued sets without using enclosing brackets. | |||
| if (case_value == value) { | |||
| ss << '.' << val_name.second; | |||
There was a problem hiding this comment.
might be nice to also make this change on line 184 and 187 in a follow-up commit.
|
Thanks! |
|
@swift-ci test |
|
I realized my added test cases needed matching |
|
@swift-ci test |
|
Is there also a matching PR for master-next? |
|
I haven't created one, sounds like I should, I will. |
|
master-next: #1735 |
kastiglione
deleted the
dl/lldb-formatter-Format-single-valued-OptionSets-w-o-brackets
branch
Special case formatting of single valued option sets to print the case name without square brackets.
For example, instead producing
[.yellow], the output will be.yellow.rdar://54106278