Skip to content

[lldb] Provide GetHomeDirectory wrapper in Host::FileSystem (NFC) #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Teemperor
Copy link

@Teemperor Teemperor commented Sep 3, 2020

Provider a wrapper around llvm::sys::path::home_directory in the
FileSystem class. This will make it possible for the reproducers to
intercept the call in a central place.

(cherry picked from commit 921c1b7)

Backported as a 040f52c (which was backported) calls this function and otherwise the branch doesn't compile.

Provider a wrapper around llvm::sys::path::home_directory in the
FileSystem class. This will make it possible for the reproducers to
intercept the call in a central place.

(cherry picked from commit 921c1b7)
@Teemperor
Copy link
Author

@swift-ci smoke test

@Teemperor
Copy link
Author

Branch is currently failing with

11:30:43  /var/lib/jenkins/workspace/apple-stable/llvm-project/lldb/source/Interpreter/CommandInterpreter.cpp:2102:26: error: no member named 'GetHomeDirectory' in 'lldb_private::FileSystem'
11:30:43    FileSystem::Instance().GetHomeDirectory(init_file);
11:30:43    ~~~~~~~~~~~~~~~~~~~~~~ ^
11:30:43  1 error generated.

@Teemperor
Copy link
Author

@swift-ci test

@Teemperor Teemperor merged commit 29af015 into swiftlang:apple/stable/20200714 Sep 3, 2020
@JDevlieghere
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants