[lldb] Fix latent compiler warnings #1775
Conversation
| return swift_flags; | ||
| LLVM_FALLTHROUGH; |
There was a problem hiding this comment.
Most of the cases in this switch use a fallthrough. Adrian do you know if it's correct for this one to be a return, not a fall through?
| if ((m_return_valobj_sp = SwiftLanguageRuntime::CalculateErrorValue( | ||
| frame_sp, persistent_variable_name))) { |
There was a problem hiding this comment.
Another case of assignment inside an if. This one looks like it should be assignment, not equality.
There was a problem hiding this comment.
Is the problem here that it's not a declaration? I.e., would if (auto m_return_valobj_sp = SwiftLa...) trigger a warning?
There was a problem hiding this comment.
Correct, a declaration would not trigger the warning. I don't know the history, but it seems clang uses additional parenthesis as a way of saying "this assignment inside an if is intentional". I see there are a number of uses of this pattern in swift and llvm.
|
@swift-ci test |
|
@swift-ci test |
| if ((m_return_valobj_sp = SwiftLanguageRuntime::CalculateErrorValue( | ||
| frame_sp, persistent_variable_name))) { |
There was a problem hiding this comment.
Is the problem here that it's not a declaration? I.e., would if (auto m_return_valobj_sp = SwiftLa...) trigger a warning?
|
I'll remember that for next time. Hopefully there won't be a next time, once https://reviews.llvm.org/D87243 is accepted we'll see warnings during development and hopefully they get fixed before committing. |
|
@swift-ci test Linux platform |
This fixes warnings identified using the
LLVM_ENABLE_WARNINGSfix in https://reviews.llvm.org/D87243.This is a follow up to the removal of unused code in #1749.