Add '<' meta command to read in statements from external file #1783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perform all error handling in ReadCode()
This loads A.swift into the REPL and executes code defined therein
jimingham
requested changes
Sep 11, 2020
There was a problem hiding this comment.
This looks great.
Can I ask you to do one more thing? In source/Expression/REPL.cpp there is a bit of text that the REPL emits when you run :help that gives an intro to REPL specific uses. It's in the function IOHandlerGetHelpPrologue. Can you add a brief sentence describing the use of the initial < meta-character? Otherwise I don't know how anyone would discover this new feature...
|
This will need to be split up. Most of it will need to go straight to llvm:master, the tests will remain in apple:swift/master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform all error handling in ReadCode()