[lldb] Remove unused version defines #1912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@shahmishal do you have any context here? seems unused |
|
@kastiglione No, I don't might be worth checking with someone who runs http://green.lab.llvm.org/green/view/LLDB/ |
|
@Teemperor do you know if anything supplies or consumes these values? |
|
Never saw them anywhere else. The git blame is also not very enlightening, so LGTM. |
Teemperor
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unused compiler defines, and related code.
LLDB_IS_BUILDBOT_BUILDLLDB_BUILD_DATEThis eliminates some downstream diff from llvm.org. See also swiftlang/swift#34212
This also removes the "fake"
LLDB_UPSTREAMdefinition, which is the inverse ofLLDB_ENABLE_SWIFT. Instead, that block of code is an#elsebranch.