Add a Transform() utility for rewriting demangle trees. (NFC) #1927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
force-pushed
the
transform-next
branch
from
9ada4e4 to
7ccb5f7
Compare
Transform() recursively transforms a demangle tree by doing a post-order traversal and replacing each node with fn(node). In most cases this utility will do less work than the ad-hoc implementation it is replacing because we now only recreate nodes that actually changed. (cherry picked from commit 347e815)
adrian-prantl
force-pushed
the
transform-next
branch
from
7ccb5f7 to
bf786c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transform() recursively transforms a demangle tree by doing a
post-order traversal and replacing each node with fn(node).
In most cases this utility will do less work than the ad-hoc
implementation it is replacing because we now only recreate nodes that
actually changed.
(cherry picked from commit e933fd7995439c8873f9a021dd5d4f5987fbd0bb)