Skip to content

fix duplicate request function registration #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

marcrasi
Copy link

@marcrasi marcrasi commented Nov 5, 2019

Upstream recently added registerIDERequestFunctions. We had previously added it as a tensorflow patch. So we're now calling it twice, which is forbidden. This PR removes our call, putting us in sync with upstream.

This fixes the following error from swiftlang/swift#28080 (comment):

lldb: /home/danielzheng/swift-merge2/swift/lib/AST/Evaluator.cpp:58: void swift::Evaluator::registerRequestFunctions(swift::Zone, ArrayRef<swift::AbstractRequestFunction *>): Assertion `zone.first != zoneID' failed.

@marcrasi marcrasi requested a review from dan-zheng November 5, 2019 18:41
@marcrasi marcrasi merged commit 44c2294 into swiftlang:swift/tensorflow Nov 5, 2019
@marcrasi marcrasi deleted the fix-duplicate-registration branch November 5, 2019 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants