[lldb][swift] Remove mydir calculation from lldbplaygroundrepl #1975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling compute_mydir on a path outside the test/API leads to bogus results and since commit fcb0d81 will also trigger a sanity assert. Also this isn't an actual test but only the base test for actual tests, so the mydir value here should be anyway unused.
|
@swift-ci test |
JDevlieghere
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling compute_mydir on a path outside the test/API leads to bogus results
and since commit fcb0d81 will also trigger a sanity assert. Also this
isn't an actual test but only the base test for actual tests, so the mydir
value here should be anyway unused.