Use the use_dynamic option to determine whether to dynamically resolve #2007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
Teemperor
reviewed
Oct 21, 2020
| @@ -14,7 +14,7 @@ func apply<Type>(_ T : Type, fn: (Type) -> Type) -> Type { return fn(T) } | |||
| public func f<Type>(_ value : Type) | |||
| { | |||
| apply(value) { arg in | |||
| return arg //% self.expect('po arg', substrs=['3735928559']) | |||
| return arg //% self.expect('expr -o -d run TestSwiftGenericStructDebugInfoGenericApply.py -- arg', substrs=['3735928559']) | |||
There was a problem hiding this comment.
Not sure if I understand this. I would say this is a typo but apparently it's passing?
PASS: lldb-api :: lang/swift/variables/generic_struct_debug_info/generic_apply/TestSwiftGenericStructDebugInfoGenericApply.py (222 of 345)
There was a problem hiding this comment.
It actually seems expr just ignores this stuff.
There was a problem hiding this comment.
I think this is an artifact of how arguments are parsed (and how I copied &pasted)
adrian-prantl
force-pushed
the
dynamic-main
branch
from
d1bfc99 to
a42807e
Compare
|
@swift-ci test |
self in Swift expressions. This is a more principled approach over always dynamically resolving all types and fixes a regression hidden by the recent @swifttest decorator bug.
adrian-prantl
force-pushed
the
dynamic-main
branch
from
a42807e to
46fd0ae
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self in Swift expressions.
This is a more principled approach over always dynamically resolving
all types and fixes a regression hidden by the recent @swifttest
decorator bug.