[lldb][swift] Make swiftTest decorator not always skip #2010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_get_bool_config_skip_if_decorator returns a decorator, but the is_not_swift_compatible function is supposed to return a bool. The skipTestIfFn is supposed to create the decorator from the function we define. As _get_bool_config_skip_if_decorator's return value is just interpreted as True, this ends up causing that we skip all Swift tests all the time. This just adds a _get_bool_config() function that actually returns a bool. We could probably also solve this by doing a function composition of the returned decorator and the decorator we create from our local function, but just having a bool seems less likely to break. (cherry picked from commit 386224a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_get_bool_config_skip_if_decorator returns a decorator, but the
is_not_swift_compatible function is supposed to return a bool. The skipTestIfFn
is supposed to create the decorator from the function we define.
As _get_bool_config_skip_if_decorator's return value is just interpreted as True,
this ends up causing that we skip all Swift tests all the time.
This just adds a _get_bool_config() function that actually returns a bool.
We could probably also solve this by doing a function composition of the
returned decorator and the decorator we create from our local function, but
just having a bool seems less likely to break.
(cherry picked from commit 386224a)