[lldb] Update Swift mangling example in type lookup
#2084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a way we can merge this without doing a clearly unnecessary test? Seems wasteful to use up all that time for a string change. |
|
We usually don't test the contents of the documentation. |
adrian-prantl
approved these changes
Nov 6, 2020
|
And since there's no tests, it seems like a waste to run tests, but I guess there's no way to merge without doing an unnecessary test run? |
|
@swift-ci test |
|
You'll still want to make sure the commit isn't accidentally breaking existing tests. |
kastiglione
deleted the
lldb-Update-Swift-mangling-example-in-type-lookup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.