[Reproducer] Disable parallel module import in SwiftASTContext during replay #211
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… replay. The Swift AST context can imports all modules in parallel. While this leads to a great performance improvement, it introduces a level of non-determinism during replay. We should disable this functionality during replay. Although it's still possible that this hides a bug, it means that at least replays will be deterministic. rdar://56947303
|
@swift-ci please test |
adrian-prantl
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Swift AST context can imports all modules in parallel. While this
leads to a great performance improvement, it introduces a level of
non-determinism during replay. We should disable this functionality
during replay. Although it's still possible that this hides a bug, it
means that at least replays will be deterministic.
rdar://56947303