Skip to content

[ScheduleDAGRRList] Pacify overload mismatch in std::min. #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Nov 6, 2020

On systems where size() doesn't return unsigned long, this leads to an
overloading mismatch. Convert the constant to whatever type is used for
Q.size() on the system.

(cherry picked from commit 6c9da99)

On systems where size() doesn't return unsigned long, this leads to an
overloading mismatch. Convert the constant to whatever type is used for
Q.size() on the system.

(cherry picked from commit 6c9da99)
@compnerd
Copy link
Member Author

compnerd commented Nov 6, 2020

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Nov 6, 2020

CC: @fhahn

Copy link

@fhahn fhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@adrian-prantl
Copy link

This LGTM, but it really should be done on LLVM.org and cherry-picked here.

@compnerd
Copy link
Member Author

compnerd commented Nov 6, 2020

@adrian-prantl - this is a cherry-pick from llvm.org

@compnerd compnerd merged commit d0e4fe0 into swiftlang:apple/stable/20200714 Nov 6, 2020
@compnerd compnerd deleted the 2100-20200714 branch November 6, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants