[lldb] Stop printing debug messages for non-failing CompilerType comparisons #2206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
friendly ping @adrian-prantl |
adrian-prantl
approved these changes
Dec 10, 2020
kastiglione
deleted the
lldb-Stop-printing-debug-messages-for-non-failing-CompilerType-comparisons
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent "TypeSystemSwiftTypeRef diverges from SwiftASTContext" debug messages for types that are equivalent.
Equivalent<CompilerType>()returns true for many types which are not strictly equal (==). For each case of equivalent-but-not-equal, the above debug message is being printed. This can appear to be an error if you're not familiar with it, and if you are it can end up being noise. With this change, the debug message is printed only if the types are not equivalent.