Skip to content

[lldb][NFC] Refactor _get_bool_config_skip_if_decorator #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2020
Merged

[lldb][NFC] Refactor _get_bool_config_skip_if_decorator #2211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions lldb/packages/Python/lldbsuite/test/decorators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,11 +815,20 @@ def skipIfAsan(func):
"""Skip this test if the environment is set up to run LLDB *itself* under ASAN."""
return skipTestIfFn(is_running_under_asan)(func)

def _get_bool_config_skip_if_decorator(key):
def _get_bool_config(key, fail_value = True):
"""
Returns the current LLDB's build config value.
:param key The key to lookup in LLDB's build configuration.
:param fail_value The error value to return when the key can't be found.
Defaults to true so that if an unknown key is lookup up we rather
enable more tests (that then fail) than silently skipping them.
"""
config = lldb.SBDebugger.GetBuildConfiguration()
value_node = config.GetValueForKey(key)
fail_value = True # More likely to notice if something goes wrong
have = value_node.GetValueForKey("value").GetBooleanValue(fail_value)
return value_node.GetValueForKey("value").GetBooleanValue(fail_value)

def _get_bool_config_skip_if_decorator(key):
have = _get_bool_config(key)
return unittest2.skipIf(not have, "requires " + key)

def skipIfCursesSupportMissing(func):
Expand Down