[lldb] Correct fallback condition in GetChildCompilerTypeAtIndex #2230
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kastiglione
commented
Dec 11, 2020
| @@ -2264,7 +2264,8 @@ CompilerType TypeSystemSwiftTypeRef::GetChildCompilerTypeAtIndex( | |||
| // Because the API deals out an index into a list of children we | |||
| // can't mix&match between the two typesystems if there is such a | |||
| // divergence. We'll need to replace all calls at once. | |||
| if (m_swift_ast_context->GetNumFields(ReconstructType(type)) < | |||
| if (m_swift_ast_context->GetNumChildren(ReconstructType(type), | |||
There was a problem hiding this comment.
is ReconstructType needed here? Why can't this call be passed type directly.
There was a problem hiding this comment.
type is an opaque pointer in TypeSystemSwiftTypeRef (a mangled name). If we want something to pass to SwiftASTContext we need to convert it to an AST type first.
|
@adrian-prantl is my assessment correct? |
adrian-prantl
approved these changes
Dec 11, 2020
|
@swift-ci test |
kastiglione
deleted the
lldb-Correct-fallback-condition-in-GetChildCompilerTypeAtIndex
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the condition to compare
GetNumChildrenimplementations. ComparingGetNumChildrentoGetNumFieldswill not always be correct.