[lldb] Implement TypeSystemSwiftTypeRef::ShouldPrintAsOneLiner #2231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return eLazyBoolCalculate; | ||
| }; | ||
| VALIDATE_AND_RETURN(impl, ShouldPrintAsOneLiner, type, | ||
| (ReconstructType(type), valobj)); |
There was a problem hiding this comment.
This looks sufficiently generic that you could hoist it all the way into the TypeSystemSwift base class and delete the SwiftASTContext implementation.
There was a problem hiding this comment.
There's nothing TypeSystemSwiftTypeRef-specific.
There was a problem hiding this comment.
That said, I'm also fine with landing it as is and doing that as an NFC refactor later.
adrian-prantl
approved these changes
Dec 11, 2020
| return eLazyBoolCalculate; | ||
| }; | ||
| VALIDATE_AND_RETURN(impl, ShouldPrintAsOneLiner, type, | ||
| (ReconstructType(type), valobj)); |
There was a problem hiding this comment.
That said, I'm also fine with landing it as is and doing that as an NFC refactor later.
|
@swift-ci test |
|
I'll do an NFC refactor later. There may be a few functions like this. |
kastiglione
deleted the
lldb-Implement-TypeSystemSwiftTypeRef-ShouldPrintAsOneLiner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
TypeSystemSwiftTypeRef::ShouldPrintAsOneLinerto match theSwiftASTContextimplementation.rdar://68171384