[lldb] Print SWIFTC in the Make invocation #2239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test linux platform |
Don't pass SWIFTC through the environment but rather make it part of the Make invocation. This makes it possible to reproduce the Make step by copying the invocation. rdar://68730409
|
@swift-ci please test |
| @@ -973,8 +973,6 @@ def run_suite(): | |||
| # Iterating over all possible architecture and compiler combinations. | |||
| os.environ["ARCH"] = configuration.arch | |||
| os.environ["CC"] = configuration.compiler | |||
| if configuration.swiftCompiler: | |||
There was a problem hiding this comment.
Why does this go away here while CC is still in the environment? Should CC also disappear? I'm just wondering because of the apparent inconsistency.
There was a problem hiding this comment.
They've already been removed upstream.
|
Thanks! This was very confusing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't pass SWIFTC through the environment but rather make it part of the
Make invocation. This makes it possible to reproduce the Make step by
copying the invocation.
rdar://68730409