Skip to content

[LLDB] Fix handling of bit-fields in a union #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2580,7 +2580,11 @@ void DWARFASTParserClang::ParseSingleMember(
// The ObjC runtime knows the byte offset but we still need to provide
// the bit-offset in the layout. It just means something different then
// what it does in C and C++. So we skip this check for ObjC types.
//
// We also skip this for fields of a union since they will all have a
// zero offset.
if (!TypeSystemClang::IsObjCObjectOrInterfaceType(class_clang_type) &&
!(parent_die.Tag() == DW_TAG_union_type && this_field_info.bit_offset == 0) &&
((this_field_info.bit_offset >= parent_bit_size) ||
(last_field_info.IsBitfield() &&
!last_field_info.NextBitfieldOffsetIsValid(
Expand Down
10 changes: 10 additions & 0 deletions lldb/test/API/lang/cpp/bitfields/TestCppBitfields.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,16 @@ def test_and_run_command(self):
self.expect("expr (clang_example.f.a)", VARIABLES_DISPLAYED_CORRECTLY,
substrs=['uint64_t', '1'])

self.expect("expr uwbf",
substrs=['a = 255',
'b = 65535',
'c = 4294967295',
'x = 4294967295'] )

self.expect("expr uwubf",
substrs=['a = 16777215',
'x = 4294967295'] )

self.expect(
"frame variable --show-types lba",
VARIABLES_DISPLAYED_CORRECTLY,
Expand Down
17 changes: 16 additions & 1 deletion lldb/test/API/lang/cpp/bitfields/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ int main(int argc, char const *argv[]) {
f.i = 1;
f.j = 0;
f.k = 1;
}
}
} clang_example;

class B {
Expand All @@ -70,6 +70,18 @@ int main(int argc, char const *argv[]) {
uint32_t d_a : 1;
} derived;

union union_with_bitfields {
unsigned int a : 8;
unsigned int b : 16;
unsigned int c : 32;
unsigned int x;
} uwbf;

union union_with_unnamed_bitfield {
unsigned int : 16, a : 24;
unsigned int x;
} uwubf;

lba.a = 2;

lbb.a = 1;
Expand All @@ -89,5 +101,8 @@ int main(int argc, char const *argv[]) {
derived.b_a = 2;
derived.d_a = 1;

uwbf.x = 0xFFFFFFFF;
uwubf.x = 0xFFFFFFFF;

return 0; // Set break point at this line.
}