Cherry-picking swiftasync support to the new stable branch. #2321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends any frame record created in the function to include that parameter, passed in X22. The new record looks like [X22, FP, LR] in memory, and FP is stored with 0b0001 stored in bits 63:60 (CodeGen assumes they are 0b0000 in normal operation). The effect of this is that tools walking the stack should expect to see one of three values there: * 0b0000 => a normal, non-extended record with just [FP, LR] * 0b0001 => the extended record [X22, FP, LR] * 0b1111 => kernel space, and a non-extended record. All other values are currently reserved. If compiling for arm64e this context pointer is address-discriminated with the discriminator 0xc31a and the DB (process-specific) key. There is also an "i8** @llvm.swift.async.context.addr()" intrinsic providing front-ends access to this slot (and forcing its creation initialized to nullptr if necessary).
This translates to "swiftasync" LLVM attribute.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci Please test linux |
1 similar comment
|
@swift-ci Please test linux |
|
@swift-ci please test linux |
|
@swift-ci Please test linux |
|
The linux failures look unrelated to this PR and also occurred on a different PR here: https://ci.swift.org/job/apple-llvm-project-pr-linux/1825 |
xymus
pushed a commit
that referenced
this pull request
Jan 15, 2021
Cherry-picking swiftasync support to the new swift/rebranch branch. (cherry picked from commit 120bf0c)
xymus
added a commit
that referenced
this pull request
Jan 15, 2021
Merge pull request #2321 from TNorthover/swiftasync-stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.