🍒/ganymede/7a204362f5c6cb97308be543f77ace8d8285ffef #2327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDevlieghere
commented
Jan 13, 2021
JDevlieghere
commented
- [DWARFLinker] Print the unsupport DWARF form as part of the warning
- [DWARFLinker] Link against BinaryFormat
- [MC] Make getEHFrameSection const like every other getter (NFC)
- [dsymutil] Warn on timestmap mismatch between object file and debug map
- [dsymutil] Copy eh_frame content into the dSYM companion file.
- [dsymutil] s/dwarfdump/llvm-dwarfdump/ in test
- [dsymutil] Fix spurious space in REQUIRES: line
- [dsymutil] Add preliminary support for DWARF 5.
(cherry picked from commit 7a20436)
(cherry picked from commit 04359ee)
(cherry picked from commit f990251)
Add a warning when the timestmap doesn't match between the object file and the debug map entry. We were already emitting such warnings for archive members and swift interface files. This patch also unifies the warning across all three. rdar://65614640 Differential revision: https://reviews.llvm.org/D94536 (cherry picked from commit e5553b9)
Copy over the __eh_frame from the binary into the dSYM. This helps kernel developers that are working with only dSYMs (i.e. no binaries) when debugging a core file. This only kicks in when the __eh_frame exists in the linked binary. Most of the time ld64 will remove the section in favor of compact unwind info. When it is emitted, it's generally small enough and should not bloat the dSYM. rdar://69774935 Differential revision: https://reviews.llvm.org/D94460 (cherry picked from commit 8a47d87)
(cherry picked from commit ad735ba)
This test is incorrectly running on non-darwin hosts. (cherry picked from commit 35e4998)
Currently dsymutil will silently fail when processing binaries with Dwarf 5 debug info. This patch adds rudimentary support for Dwarf 5 in dsymutil. - Recognize relocations in the debug_addr section. - Recognize (a subset of) Dwarf 5 form values. - Emits valid Dwarf 5 compile unit header chains. To simplify things (and avoid having to emit indexed sections) I decided to emit the relocated addresses directly in the debug info section. - DW_FORM_strx gets relocated and rewritten to DW_FORM_strp - DW_FORM_addrx gets relocated and rewritten to DW_FORM_addr Obviously there's a lot of work left, but this should be a step in the right direction. rdar://62345491 Differential revision: https://reviews.llvm.org/D94323 (cherry picked from commit f1d5cbb)
|
@swift-ci please test macos |
JDevlieghere
deleted the
🍒/ganymede/7a204362f5c6cb97308be543f77ace8d8285ffef
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.