Temporarily mark swiftasync unsupported for x86_64 Windows #2692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
varungandhi-apple
force-pushed
the
vg-apple/stable
branch
from
e3d5171 to
93d7b76
Compare
The new ABI needs stack adjustment, but on Windows, swifttailcc only works if there is no stack adjustment.
varungandhi-apple
force-pushed
the
vg-apple/stable
branch
from
93d7b76 to
d302e70
Compare
|
@swift-ci test |
aschwaighofer
pushed a commit
to aschwaighofer/llvm-project
that referenced
this pull request
Mar 17, 2021
Temporarily mark swiftasync unsupported for x86_64 Windows (cherry picked from commit 73e4a09)
|
CC @compnerd |
|
Is the problematic line. After swiftlang/swift#36281 we emit variable number of llvm arguments between async caller and callee so we will trigger that assert. |
shahmishal
added a commit
that referenced
this pull request
Mar 17, 2021
Cherry-pick to swift/main: Merge pull request #2692 from varungandhi-apple/vg-apple/stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new ABI needs stack adjustment, but on Windows, swifttailcc only
works if there is no stack adjustment.