Cache the results of SwiftASTContext::GetCompileUnitImports() #2719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
Teemperor
reviewed
Mar 19, 2021
Every time a scratch context is requested, a call to GetCompileUnitImports() is made, which is both expensive and redundant. This patch adds a cache that keeps track of compile units for which the imports were already performed. This results in a measurable performance improvement on the LLDB test suite. rdar://75381959
adrian-prantl
force-pushed
the
75381959-1
branch
from
f8bc082 to
7b1707a
Compare
|
Thanks @Teemperor ! |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time a scratch context is requested, a call to
GetCompileUnitImports() is made, which is both expensive and
redundant. This patch adds a cache that keeps track of compile units
for which the imports were already performed. This results in a
measurable performance improvement on the LLDB test suite.
rdar://75381959
This patch is much better than the original one, because it has an extra
!!