Skip to content

Revert "Cherry-pick two upstream lit changes to optimize swift testing performance" #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

edymtt
Copy link

@edymtt edymtt commented Mar 24, 2021

Reverts #2687

This change will cause fallout on Swift bots running Ubuntu 16.04, which are running Python 3.5, which a failure similar to

 cd /Users/docker_user/src/build/buildbot_incremental/llbuild-linux-x86_64/tests && /usr/bin/python3.5 /Users/docker_user/src/llvm-project/llvm/utils/lit/lit.py -sv --param build_mode=Release /Users/docker_user/src/build/buildbot_incremental/llbuild-linux-x86_64/tests
Traceback (most recent call last):
  File "/Users/docker_user/src/llvm-project/llvm/utils/lit/lit.py", line 3, in <module>
    from lit.main import main
  File "/Users/docker_user/src/llvm-project/llvm/utils/lit/lit/main.py", line 13, in <module>
    import lit.cl_arguments
  File "/Users/docker_user/src/llvm-project/llvm/utils/lit/lit/cl_arguments.py", line 11, in <module>
    class TestOrder(enum.Enum):
  File "/Users/docker_user/src/llvm-project/llvm/utils/lit/lit/cl_arguments.py", line 12, in TestOrder
    DEFAULT = enum.auto()
AttributeError: module 'enum' has no attribute 'auto'

Addresses rdar://75786134

@edymtt
Copy link
Author

edymtt commented Mar 24, 2021

@swift-ci please test

@edymtt edymtt requested a review from porglezomp March 24, 2021 23:49
@edymtt
Copy link
Author

edymtt commented Mar 25, 2021

This is also affecting PR testing, e.g. #2745

Copy link

@davezarzycki davezarzycki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to just fix the underlying problem and not revert the cherry picks wholesale. Can we please abandon this in favor of #2749? Thanks!

@edymtt edymtt closed this Mar 25, 2021
@edymtt edymtt deleted the revert-2687-record_and_reorder_tests branch March 25, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants