Skip to content

ARM: mark swiftself register (r10) as caller saved for swifttailcc #2750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TNorthover
Copy link

The tail call mechanism used for most calls means that if it's callee-saved the
argument we're intending to pass will be clobbered.

rdar://75812090

The tail call mechanism used for most calls means that if it's callee-saved the
argument we're intending to pass will be clobbered.

rdar://75812090
@TNorthover
Copy link
Author

@swift-ci please test

Copy link

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@aschwaighofer
Copy link

The linux failure should be fixed by #2749

@aschwaighofer
Copy link

@swift-ci please test linux

@TNorthover TNorthover merged commit b52ea9d into swiftlang:apple/stable/20210107 Mar 25, 2021
@TNorthover TNorthover deleted the arm-swiftself-csr branch March 25, 2021 16:59
aschwaighofer pushed a commit to aschwaighofer/llvm-project that referenced this pull request Mar 25, 2021
…/main

ARM: mark swiftself register (r10) as caller saved for swifttailcc

(cherry picked from commit b52ea9d)
hyp added a commit that referenced this pull request Mar 26, 2021
…-csr

Cherry-pick #2750 from apple/stable/20210107 to swift/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants