Skip to content

Fix Objective-C runtime code on Catalina and re-enable tests #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 5, 2021
Merged

Fix Objective-C runtime code on Catalina and re-enable tests #2777

merged 3 commits into from
Apr 5, 2021

Conversation

JDevlieghere
Copy link

No description provided.

@JDevlieghere
Copy link
Author

@swift-ci please test

@JDevlieghere JDevlieghere force-pushed the lazily-named-classes branch from 181baf4 to a67bf3d Compare April 2, 2021 07:21
@JDevlieghere
Copy link
Author

Rebased after #2775 was merged.

@swift-ci please test

@JDevlieghere
Copy link
Author

@swift-ci please test

@JDevlieghere
Revert "XFAIL failing lldb tests"
7e69a5b 
This reverts commit 7357afe.
@JDevlieghere
[lldb] Re-enable {Set|Dict}Bridging.test
e4dea3b 
These tests were broken because we couldn't read the lazily named
classes. With that issue resolved, these tests pass again.
@JDevlieghere
[lldb] Account for objc_debug_class_getNameRaw returning NULL
68c9ce8 
On macOS Catalina, calling objc_debug_class_getNameRaw on some of the
ISA pointers returns NULL, causing us to crash and unwind before reading
all the Objective-C classes. This does not happen on macOS Big Sur.
Account for that possibility and skip the class when that happens.

(cherry picked from commit cf51bf7)
(cherry picked from commit 756f6e2)
@JDevlieghere JDevlieghere force-pushed the lazily-named-classes branch from a67bf3d to 68c9ce8 Compare April 2, 2021 14:43
@JDevlieghere
Copy link
Author

@swift-ci please test

1 similar comment
@JDevlieghere
Copy link
Author

@swift-ci please test

@JDevlieghere
Copy link
Author 

sourcekit: [1:ping-event-handler:11787:10.0302] service restored[2021-04-03 02:23:33.321] failed to close document missingDocument(LanguageServerProtocol.DocumentURI(storage: file:///Users/buildnode/jenkins/workspace/apple-llvm-project-pr-macos/buildbot_incremental/sourcekitlsp-macosx-x86_64/x86_64-apple-macosx/release/SourceKitLSP_SKTestSupport.bundle/INPUTS/sourcekitdCrashRecovery/main.swift))
[2021-04-03 02:23:33.329] error response (Request Failed): semantic editor is disabled
[2021-04-03 02:23:33.329] cursor info failed DocumentURI(storage: file:///Users/buildnode/jenkins/workspace/apple-llvm-project-pr-macos/buildbot_incremental/sourcekitlsp-macosx-x86_64/x86_64-apple-macosx/release/SourceKitLSP_SKTestSupport.bundle/INPUTS/sourcekitdCrashRecovery/main.swift):2:7: ResponseError(code: LanguageServerProtocol.ErrorCode(rawValue: -32001), message: "sourcekitd request failed: error response (Request Failed): semantic editor is disabled")

@JDevlieghere
Copy link
Author

@swift-ci please test

@JDevlieghere
Copy link
Author 

clang-10: error: unable to execute command: Killed: 9

@JDevlieghere
Copy link
Author

@swift-ci please test

@JDevlieghere JDevlieghere merged commit 2895d0c into swift/main Apr 5, 2021
@JDevlieghere JDevlieghere deleted the lazily-named-classes branch April 5, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JDevlieghere