Cherry-pick Python3 changes to apple/stable/20210107 #2804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 6, 2021 15:45
We can now use Python3. Let's use `os.cpu_count()` to cleanup this helper. Differential Revision: https://reviews.llvm.org/D94734 (cherry picked from commit 9946b16)
Update shebang to always use Python3 when executing `lit.py` directly. A previous change of mine [1] revealed that we still use Python2 on some bot configurations that invoke `llvm/utils/lit/lit.py` as a script directly (instead of `python3 path/to/lit.py`). [1] https://reviews.llvm.org/D94734 Differential Revision: https://reviews.llvm.org/D95393 (cherry picked from commit 6f1d4fb)
varungandhi-apple
force-pushed
the
vg-python3-is-lit
branch
from
66c1b0d to
8164616
Compare
|
@swift-ci test |
yln
approved these changes
Apr 6, 2021
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were missing since we branched after they were merged, which is annoying for developers at their desks as they need to use
python3 path/to/lit.pyexplicitly.