X86: enable proper frame lowering for swift async on Win64 #2855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Swift asynchronous calling convention requires some additional setup on the frame. In particular, the swift async register needs to be spilled relative to the frame pointer, which we now accommodate. This may require some further refinement due to frame setup restrictions on Windows, but this initial approach should be sufficient to move towards a working asynchronous support.
|
@swift-ci please test |
|
CC: @gottesmm |
|
@compnerd Can you upstream this patch? Doing so should get rid of the "Check File(s) Changed" failure I think. Also you would get a proper review. @TNorthover has recently upstreamed |
|
@aschwaighofer yes, I do intend to try to upstream the work, but this is needed to get the tests enabled, and Id like to get the test coverage as high as possible to uncover any possible ABI level issues that may be lurking as a result of all the disabled tests. |
|
@shahmishal Can you merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Swift asynchronous calling convention requires some additional setup
on the frame. In particular, the swift async register needs to be
spilled relative to the frame pointer, which we now accommodate. This
may require some further refinement due to frame setup restrictions on
Windows, but this initial approach should be sufficient to move towards
a working asynchronous support.