Skip to content

[lldb] Exclude "resume partial" prefix from demangled display name #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kastiglione
Copy link

When generating a display name for async resume partial functions, use the top-level function name. This primary purpose of this change is to display frames in backtraces using the function names found in source code. This will match developer expectations.

For demonstration, instead of a backtrace like this:

asyncHelper() at main.swift:2
(1) await resume partial function for static Main.main() at main.swift:13

with this change the backtrace will be:

asyncHelper() at main.swift:2
static Main.main() at main.swift:13

Depends on swiftlang/swift#36978

@adrian-prantl
Copy link

Nice. Thanks for doing this!

@kastiglione
Copy link
Author

@swift-ci test

@kastiglione kastiglione merged commit f7bf184 into swift/main Apr 21, 2021
@kastiglione kastiglione deleted the lldb-Exclude-resume-partial-prefix-from-demangled-display-name branch April 21, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants