-
Notifications
You must be signed in to change notification settings - Fork 342
[lldb] Move SwiftLanguageRuntime to its own plugin #2884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks, I think this is a long-overdue refactoring, but we need to do this on all branches (i.e., also on the swift-5.5 branch) at the same time or we'll end up with a lot of merge conflicts. There is never a good time to make these kinds of changes, but by doing them on all branches at the same time, we can minimize the impact. |
also |
f8c27de
to
fe0ab91
Compare
Once this change looks good to y'all, I can create PRs for other branches in order to try to reduce the amount of friction. Just let me know if there's anything else that can be improved/changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM
fe0ab91
to
10b80f5
Compare
Everything else should be handled by the automerger. Thanks! |
@swift-ci please test edit: ugh, didn't check the target branch. |
@JDevlieghere Could you also merge this one when you have the time? Thanks! |
The automerger from 5.5 -> main should take care of that for us. |
Awesome, I'll close this PR then. |
Motivation: I want to move swift-specific behavior into plugins in order to reduce friction between upstream lldb and the swift variant. Moving swift-specific classes out of Target into plugins is a good place to start I think.
cc @kastiglione @adrian-prantl