Skip to content

[lldb] Move SwiftLanguageRuntime to its own plugin #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

bulbazord
Copy link

Motivation: I want to move swift-specific behavior into plugins in order to reduce friction between upstream lldb and the swift variant. Moving swift-specific classes out of Target into plugins is a good place to start I think.

cc @kastiglione @adrian-prantl

@adrian-prantl
Copy link

Thanks, I think this is a long-overdue refactoring, but we need to do this on all branches (i.e., also on the swift-5.5 branch) at the same time or we'll end up with a lot of merge conflicts. There is never a good time to make these kinds of changes, but by doing them on all branches at the same time, we can minimize the impact.

@kastiglione
Copy link

also swift/next

@bulbazord bulbazord force-pushed the move-swift-lang-runtime branch from f8c27de to fe0ab91 Compare April 23, 2021 20:47
@bulbazord
Copy link
Author

Once this change looks good to y'all, I can create PRs for other branches in order to try to reduce the amount of friction. Just let me know if there's anything else that can be improved/changed.

Copy link

@JDevlieghere JDevlieghere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@bulbazord
Copy link
Author

I opened PRs for swift/next and swift/release/5.5. Let me know if there are other branches.

swift/next: #2899
swift/release/5.5: #2898 and #2887

@adrian-prantl
Copy link

Everything else should be handled by the automerger. Thanks!

@JDevlieghere
Copy link

JDevlieghere commented Apr 30, 2021

@swift-ci please test

edit: ugh, didn't check the target branch.

@bulbazord
Copy link
Author

@JDevlieghere Could you also merge this one when you have the time? Thanks!

@JDevlieghere
Copy link

The automerger from 5.5 -> main should take care of that for us.

@bulbazord
Copy link
Author

bulbazord commented May 4, 2021

Awesome, I'll close this PR then.

@bulbazord bulbazord closed this May 4, 2021
@bulbazord bulbazord deleted the move-swift-lang-runtime branch May 4, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants