Skip to content

[lldb] Implement TypeSystemSwiftTypeRef::GetNumTemplateArguments #2892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2021
Merged

[lldb] Implement TypeSystemSwiftTypeRef::GetNumTemplateArguments #2892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc65450
Implement TypeSystemSwiftTypeRef::GetNumTemplateArguments
augusto2112 Apr 28, 2021
9df8052
Add GetNumTemplateArguments test to TestTypeSystemSwiftTypeRef
augusto2112 Apr 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2616,8 +2616,37 @@ size_t TypeSystemSwiftTypeRef::GetIndexOfChildMemberWithName(

size_t
TypeSystemSwiftTypeRef::GetNumTemplateArguments(opaque_compiler_type_t type) {
return m_swift_ast_context->GetNumTemplateArguments(ReconstructType(type));
auto impl = [&]() -> size_t {
using namespace swift::Demangle;
Demangler dem;
NodePointer node = DemangleCanonicalType(dem, type);

if (!node)
return 0;

switch (node->getKind()) {
case Node::Kind::BoundGenericClass:
case Node::Kind::BoundGenericEnum:
case Node::Kind::BoundGenericStructure:
case Node::Kind::BoundGenericProtocol:
case Node::Kind::BoundGenericOtherNominalType:
case Node::Kind::BoundGenericTypeAlias:
case Node::Kind::BoundGenericFunction: {
if (node->getNumChildren() > 1) {
NodePointer child = node->getChild(1);
if (child && child->getKind() == Node::Kind::TypeList)
return child->getNumChildren();
}
} break;
default:
break;
}
return 0;
};
VALIDATE_AND_RETURN(impl, GetNumTemplateArguments, type,
(ReconstructType(type)), (ReconstructType(type)));
}

CompilerType
TypeSystemSwiftTypeRef::GetTypeForFormatters(opaque_compiler_type_t type) {
return m_swift_ast_context->GetTypeForFormatters(ReconstructType(type));
Expand Down
62 changes: 62 additions & 0 deletions lldb/unittests/Symbol/TestTypeSystemSwiftTypeRef.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,3 +577,65 @@ TEST_F(TestTypeSystemSwiftTypeRef, ImportedType) {
TEST_F(TestTypeSystemSwiftTypeRef, RawPointer) {
ASSERT_EQ(m_swift_ts.GetRawPointerType().GetMangledTypeName(), "$sBpD");
}

TEST_F(TestTypeSystemSwiftTypeRef, GetNumTemplateArguments) {
using namespace swift::Demangle;
Demangler dem;
NodeBuilder b(dem);
{
NodePointer n = b.GlobalType(b.Node(
Node::Kind::BoundGenericClass,
b.Node(Node::Kind::Type,
b.Node(Node::Kind::Class, b.Node(Node::Kind::Module, "module"),
b.Node(Node::Kind::Identifier, "Foo"))),
b.Node(Node::Kind::TypeList,
b.Node(Node::Kind::Type,
b.Node(Node::Kind::DependentGenericParamType,
b.NodeWithIndex(Node::Kind::Index, 0),
b.NodeWithIndex(Node::Kind::Index, 0))),
b.Node(Node::Kind::Type,
b.Node(Node::Kind::DependentGenericParamType,
b.NodeWithIndex(Node::Kind::Index, 0),
b.NodeWithIndex(Node::Kind::Index, 1))),
b.Node(Node::Kind::Type,
b.Node(Node::Kind::DependentGenericParamType,
b.NodeWithIndex(Node::Kind::Index, 0),
b.NodeWithIndex(Node::Kind::Index, 2))))));
CompilerType t = GetCompilerType(b.Mangle(n));
ASSERT_EQ(t.GetNumTemplateArguments(), 3);
}

{
NodePointer n = b.GlobalType(b.Node(
Node::Kind::BoundGenericStructure,
b.Node(Node::Kind::Type,
b.Node(Node::Kind::Structure, b.Node(Node::Kind::Module, "module"),
b.Node(Node::Kind::Identifier, "Foo"))),
b.Node(Node::Kind::TypeList,
b.Node(Node::Kind::Type,
b.Node(Node::Kind::DependentGenericParamType,
b.NodeWithIndex(Node::Kind::Index, 0),
b.NodeWithIndex(Node::Kind::Index, 0))),
b.Node(Node::Kind::Type,
b.Node(Node::Kind::DependentGenericParamType,
b.NodeWithIndex(Node::Kind::Index, 0),
b.NodeWithIndex(Node::Kind::Index, 1))))));
CompilerType t = GetCompilerType(b.Mangle(n));
ASSERT_EQ(t.GetNumTemplateArguments(), 2);
}

{
NodePointer n = b.GlobalType(b.Node(
Node::Kind::BoundGenericEnum,
b.Node(Node::Kind::Type,
b.Node(Node::Kind::Enum, b.Node(Node::Kind::Module, "module"),
b.Node(Node::Kind::Identifier, "Foo"))),
b.Node(Node::Kind::TypeList,
b.Node(Node::Kind::Type,
b.Node(Node::Kind::DependentGenericParamType,
b.NodeWithIndex(Node::Kind::Index, 0),
b.NodeWithIndex(Node::Kind::Index, 0))))));
CompilerType t = GetCompilerType(b.Mangle(n));
ASSERT_EQ(t.GetNumTemplateArguments(), 1);
}
}