Improve diagnostics for import failures #2919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the expression evaluator. rdar://76217088
|
@swift-ci test |
… buffers. Without this, module import failures in the expression evaluator are completely opaque to the end-user and they need to look at the types log. rdar://76217088
adrian-prantl
force-pushed
the
better-diagnostics
branch
from
3af6f87 to
2ce057c
Compare
|
@swift-ci test |
kastiglione
approved these changes
May 6, 2021
| // Append any last remaining text. | ||
| if (start_pos < diagnostic.description.size()) | ||
| if (first_line > 0 && bufferID != UINT32_MAX) { | ||
| // Make sure the error line is in range or in another file. |
There was a problem hiding this comment.
or in another file
maybe I don't know this code, but is this supposed to be "and not in another file"
diagnostic.bufferID == bufferID
There was a problem hiding this comment.
The code wants to suppress all errors that are in the main buffer and out of range. It displays all errors that are either
- in the main buffer inside the range
- in another file
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://76217088