[lldb] Implement TypeSystemSwiftTypeRef::IsTypedefType and TypeSystemSwiftTypeRef::GetTypedefedType #2936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
kastiglione
reviewed
May 7, 2021
lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
Outdated
Show resolved
Hide resolved
lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp
Outdated
Show resolved
Hide resolved
…peRef::GetTypedefedType
augusto2112
force-pushed
the
ts-swift-typeref-typealias
branch
from
f42965e to
bc24cef
Compare
|
@swift-ci test |
kastiglione
approved these changes
May 10, 2021
| if (!node || node->getKind() != Node::Kind::TypeAlias) | ||
| return {}; | ||
| auto pair = ResolveTypeAlias(m_swift_ast_context, dem, node); | ||
| if (NodePointer resolved = std::get<swift::Demangle::NodePointer>(pair)) { |
There was a problem hiding this comment.
since this function has using namespace swift::Demangle, you don't need the fully qualified <swift::Demangle::NodePointer>, it could be reduced to <NodePointer>. Feel free to merge, not worth another round of testing to change just this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adrian-prantl since we need debug info to resolve a typedef, is it possible to unit test
TypeSystemSwiftTypeRef::GetTypedefedType?rdar://68171433
rdar://68171443