Skip to content

Get more info if lldbutil.run_to_XXX_breakpoint doesn't hit the break… #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jimingham
Copy link

…point.

We interrupt the process. If that fails, we report the error. If it
stops the process successfully, we print the stacktraces for all the
threads in the inferior so we can see whether it overshot the breakpoint,
or stalled before getting to it, etc...

The bots are showing a failure in TestSwiftDeploymentTarget.py. The error is that the process state in lldbutil.run_to_source_breakpoint is "eStateRunning". I can't repro the problem, so I need to get more info
from the merge bot about where the process actually is.

…point.

We interrupt the process.  If that fails, we report the error.  If it
stops the process successfully, we print the stacktraces for all the
threads in the inferior so we can see whether it overshot the breakpoint,
or stalled before getting to it, etc...
@jimingham
Copy link
Author

@swift-ci please test macos

Copy link

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also do this upstream?

@jimingham
Copy link
Author

Shouldn't we also do this upstream?

For sure, I just wanted to get this into the sources the merge bot is testing so I can see why we are getting a failure in TestSwiftDeploymentTarget.py. Going through llvm -> here would be slower.

@jimingham jimingham merged commit 1c0b39d into swiftlang:apple/stable/20210107 May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants