[DebugInfo] Fix DWARF expressions for __block vars that are not on th… #2968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e heap `__block` variables used to be always stored on the head instead of stack. D51564 allowed `__block` variables to the stored on the stack like normal variablesif they not captured by any escaping block, but the debug-info generation code wasn't made aware of it so we still unconditionally emit DWARF expressions pointing to the heap. This patch makes CGDebugInfo use the `EscapingByref` introduced in D51564 that tracks whether the `__block` variable is actually on the heap. If it's stored on the stack instead we just use the debug info we would generate for normal variables instead. Reviewed By: ahatanak, aprantl Differential Revision: https://reviews.llvm.org/D99946 (cherry picked from commit 888ce70)
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e heap
__blockvariables used to be always stored on the head instead of stack.D51564 allowed
__blockvariables to the stored on the stack like normalvariablesif they not captured by any escaping block, but the debug-info
generation code wasn't made aware of it so we still unconditionally emit DWARF
expressions pointing to the heap.
This patch makes CGDebugInfo use the
EscapingByrefintroduced in D51564 thattracks whether the
__blockvariable is actually on the heap. If it's stored onthe stack instead we just use the debug info we would generate for normal
variables instead.
Reviewed By: ahatanak, aprantl
Differential Revision: https://reviews.llvm.org/D99946
(cherry picked from commit 888ce70)