Skip to content

Update the crashlog.py shebang to run under Python 3 #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Update the crashlog.py shebang to run under Python 3 #3015

merged 1 commit into from
Jun 4, 2021

Conversation

JDevlieghere
Copy link

rdar://78629167

@JDevlieghere
Copy link
Author

@swift-ci please test

Copy link

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be done on llvm.org?

@adrian-prantl
Copy link

lldb/test/Shell/ScriptInterpreter/Python/Crashlog/text.test is also running on Linux. Could hardcoding the name like this be a problem?

@adrian-prantl
Copy link

The test doesn't depend on the shebang though

@adrian-prantl
Copy link

I see the discussion for upstream is still going on

@adrian-prantl adrian-prantl self-requested a review May 28, 2021 20:32
@JDevlieghere
Copy link
Author

JDevlieghere commented May 28, 2021

I see the discussion for upstream is still going on

Yes, and we really want this path to point to the Python 3 interpreter from Xcode (which /usr/bin/python3 is a shim for).

@JDevlieghere
Copy link
Author

@swift-ci please test macos platform

@JDevlieghere JDevlieghere merged commit 39cfac1 into swiftlang:swift/release/5.5 Jun 4, 2021
@JDevlieghere JDevlieghere deleted the rdar78629167 branch June 4, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants