Skip to content

After removing overlays from Swift repo we are started seeing followi… #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

shahmishal
Copy link
Member

…ng failures

  • lldb-api :: lang/swift/foundation_value_types/indexpath/TestSwiftFoundationTypeIndexPath.py
  • lldb-shell :: SwiftREPL/FoundationTypes.test
  • lldb-shell :: SwiftREPL/ResilientArray.test
  • lldb-shell :: SwiftREPL/ResilientDict.test

…ng failures

* lldb-api :: lang/swift/foundation_value_types/indexpath/TestSwiftFoundationTypeIndexPath.py
* lldb-shell :: SwiftREPL/FoundationTypes.test
* lldb-shell :: SwiftREPL/ResilientArray.test
* lldb-shell :: SwiftREPL/ResilientDict.test
@shahmishal
Copy link
Member Author

@swift-ci test

@adrian-prantl
Copy link

Preferably we XFAIL the tests, so we get notified when their status changes.

@adrian-prantl
Copy link

We can also merge this and change it to XFAILs in a follow-up commit

@shahmishal
Copy link
Member Author

@swift-ci test

@shahmishal shahmishal requested a review from adrian-prantl June 10, 2021 07:03
@adrian-prantl
Copy link

03:05:55 Unexpectedly Passed Tests (4):
03:05:55   lldb-api :: lang/swift/foundation_value_types/indexpath/TestSwiftFoundationTypeIndexPath.py
03:05:55   lldb-shell :: SwiftREPL/FoundationTypes.test
03:05:55   lldb-shell :: SwiftREPL/ResilientArray.test
03:05:55   lldb-shell :: SwiftREPL/ResilientDict.test

Is that because it wasn't tested against the PR that removes the overlays?

@shahmishal
Copy link
Member Author

Yes, its because it was not tested with swift PR. I will merge both PRs together.

@shahmishal shahmishal merged commit d51e99d into swift/main Jun 10, 2021
@shahmishal shahmishal deleted the shahmishal/skip-test-foundation branch June 10, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants