Swift-next Cherry-pick: Swift async calling conventions #3060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is intended as initial setup. The plan is to add more semantic checks later. Most of the code closely mirrors that for the Swift calling convention. Three places are marked as [FIXME: swiftasynccc]; those will be addressed in follow-up commits. Differential Revision: https://reviews.llvm.org/D95561 (cherry-pick to apple/stable/20210107 from not-yet-merged revision)
swifttailcc is a new calling convention in LLVM introduced in https://reviews.llvm.org/D95443. We add a new DWARF tag to capture this in debuginfo. Differential Revision: https://reviews.llvm.org/D95704 (cherry-pick to apple/stable/20210107 from not-yet-merged revision)
1. It should be mapped to LLVM's swifttailcc, which is now available. 2. We should make sure we generate a tail call instead of an ordinary call. Fixes rdar://73762895. Differential Revision: https://reviews.llvm.org/D95984
edymtt
pushed a commit
to edymtt/llvm-project
that referenced
this pull request
Jul 8, 2021
…ft-async-calling-conventions Swift-next Cherry-pick: Swift async calling conventions (cherry picked from commit 0fa8fb6)
|
These patches should have come from llvm.org upstream. @varungandhi-apple it should now be possible to commit those patches because Tim has upstreamed |
|
Yes, I made some updates, working on landing them. |
etcwilde
deleted the
ewilde/swift-next/swift-async-calling-conventions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is necessary for building the next swift compiler on the next llvm.
It was merged into current after things stabilized I guess(?), so it wasn't merged into the next branch.
rdar://79631095